[PATCH v2 19/25] pxa2xx-flash: switch from ioremap_cache to memremap

From
Dan Williams <hidden>
Date
2015-10-09 21:33:25
Also in
linux-arch, lkml, nvdimm
Reply to
Brian Norris, 2015-10-02
On Fri, Oct 2, 2015 at 10:51 AM, Brian Norris
[off-list ref] wrote:
+ linux-mtd

On Fri, Jul 24, 2015 at 10:39:45PM -0400, Dan Williams wrote:
quoted
In preparation for deprecating ioremap_cache() convert its usage in
pxa2xx-flash to memremap.

Cc: David Woodhouse <dwmw2@infradead.org>
Cc: Brian Norris <computersforpeace@gmail.com>
Signed-off-by: Dan Williams <redacted>
---
 drivers/mtd/maps/pxa2xx-flash.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/maps/pxa2xx-flash.c b/drivers/mtd/maps/pxa2xx-flash.c
index 12fa75df5008..758a8a7f86d9 100644
--- a/drivers/mtd/maps/pxa2xx-flash.c
+++ b/drivers/mtd/maps/pxa2xx-flash.c
@@ -71,8 +71,8 @@ static int pxa2xx_flash_probe(struct platform_device *pdev)
                     info->map.name);
              return -ENOMEM;
      }
-     info->map.cached =
-             ioremap_cache(info->map.phys, info->map.size);
+     info->map.cached = memremap(info->map.phys, info->map.size,
+                     MEMREMAP_CACHE);
Should the corresponding iounmap() be changed too? Looks like a pretty
thin wrapper right now, but it seems like the API would suggest we do
this anyway.
Yes, thanks for that catch, addressed in the next rev.
Thread (67 messages) 67 messages, 10 authors, last reply 2016-04-21
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help