Thread (13 messages) 13 messages, 3 authors, 2015-10-07

[PATCH v2 2/3] nvmem: core: set the size for the nvmem binary file.

From: Srinivas Kandagatla <hidden>
Date: 2015-10-07 13:22:00
Also in: lkml


On 07/10/15 13:56, Greg KH wrote:
On Wed, Oct 07, 2015 at 12:00:55PM +0100, Srinivas Kandagatla wrote:
quoted
This patch sets the actual size of binary file to the nvmem size.
Previously this was not possible as the core was using the static global
data structures for attributes.

Signed-off-by: Srinivas Kandagatla <redacted>
---
  drivers/nvmem/core.c | 1 +
  1 file changed, 1 insertion(+)
diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
index 0a70e31..737fa75 100644
--- a/drivers/nvmem/core.c
+++ b/drivers/nvmem/core.c
@@ -315,6 +315,7 @@ struct nvmem_device *nvmem_register(const struct nvmem_config *config)
  	if (!nvmem->read_only)
  		nvmem->bin.attr.mode |= S_IWUSR;

+	nvmem->bin.size = nvmem->size;
Why does the size matter?  What userspace tool needs to know this?
Yes, you are correct, sized should not matter as read would return EOF 
anyway.
I think I overdone this :-)

--srini
thanks,

greg k-h
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help