Thread (44 messages) 44 messages, 6 authors, 2015-10-06

[RFC/PATCH 00/11] arm: omap: counter32k rework

From: tony@atomide.com (Tony Lindgren)
Date: 2015-10-05 10:56:03
Also in: linux-omap, linux-tegra, lkml

* Daniel Lezcano [off-list ref] [151001 15:16]:
On 09/30/2015 04:49 PM, Arnd Bergmann wrote:
quoted
On Wednesday 30 September 2015 16:42:21 Arnd Bergmann wrote:
quoted
TEGRA folks: the tegra_read_persistent_clock() implementation apparently
predates the Tegra RTC driver and I wonder if they actually do the
right thing in combination. Could it be that the wall time forwards
twice as fast as it should during resume when the RTC driver is loaded?
Could it be that we can simply remove  tegra_read_persistent_clock()
and the register_persistent_clock() infrastructure?
I found the 'sleeptime_injected' variable now, which takes care of
forwarding the clock by the correct amount.

I also found the CLOCK_SOURCE_SUSPEND_NONSTOP flag next to it, which
should let us use the counter32k driver to provide the correct
time during suspend without the omap_read_persistent_clock() function.
We should be able to just delete that code.

If we decide to also delete the tegra_read_persistent_clock()
function, we can remove the registration too.

+1
We could maybe have read_persistent_clock() just check for the
CLOCK_SOURCE_SUSPEND_NONSTOP flag?

And we probably should have also has_persistent_clock() or something
that also checks for the CLOCK_SOURCE_SUSPEND_NONSTOP.

Regards,

Tony
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help