Thread (4 messages) 4 messages, 3 authors, 2015-10-04

[PATCH V5 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock'

From: gregkh@linuxfoundation.org (Greg Kroah-Hartman)
Date: 2015-10-04 09:54:11
Also in: alsa-devel, linux-acpi, linux-bluetooth, linux-iommu, linux-mm, linux-scsi, linux-wireless, lkml, netdev

On Sun, Sep 27, 2015 at 03:48:24PM +0200, Rafael J. Wysocki wrote:
On Sun, Sep 27, 2015 at 12:04 AM, Viresh Kumar [off-list ref] wrote:
quoted
global_lock is defined as an unsigned long and accessing only its lower
32 bits from sysfs is incorrect, as we need to consider other 32 bits
for big endian 64-bit systems. There are no such platforms yet, but the
code needs to be robust for such a case.

Fix that by changing type of 'global_lock' to u32.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Acked-by: Rafael J. Wysocki <redacted>

Greg, please take this one along with the [2/2] if that one looks good to you.
Thanks, will do.

greg k-h
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help