On Thu, Sep 03 2015 at 21:59 -0600, Stephen Boyd wrote:

On 09/03, Lina Iyer wrote:

quoted

@@ -137,7 +138,6 @@ int __cpu_up(unsigned int cpu, struct task_struct *idle)
 		pr_err("CPU%u: failed to boot: %d\n", cpu, ret);
 	}

-

Please remove noise.

Sorry, I forgot to address it earlier. Thought I did.
Apologize.

quoted

 	memset(&secondary_data, 0, sizeof(secondary_data));
 	return ret;
 }

@@ -271,6 +271,16 @@ void __cpu_die(unsigned int cpu)
 void __ref cpu_die(void)
 {
 	unsigned int cpu = smp_processor_id();
+	struct device *cpu_dev;
+
+	/*
+	 * We dont need the CPU device anymore.

s/dont/don't/

quoted

+	 * Lets do this before IRQs are disabled to allow

s/Lets/Let's/

quoted

+	 * runtime PM to suspend the domain as well.
+	 */

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project