Thread (5 messages) 5 messages, 3 authors, 2015-09-30

[PATCH 2/2] clocksource/drivers/keystone: Fix bad NO_IRQ usage

flat view

From: santosh shilimkar <hidden>
Date: 2015-09-30 15:27:17
Also in: lkml

On 9/30/2015 3:08 AM, Daniel Lezcano wrote:
The current code assumes the 'irq_of_parse_and_map' will return NO_IRQ in case
of failure. Unfortunately, the NO_IRQ is not consistent across the different
architectures and we must not rely on it.

NO_IRQ is equal to '-1' on ARM and 'irq_of_parse_and_map' returns '0' in case
of an error. Hence, the latter won't be detected and will lead to a crash.

Fix this by just checking 'irq' is different from zero.

Signed-off-by: Daniel Lezcano <redacted>
---
  drivers/clocksource/timer-keystone.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Santosh Shilimkar <ssantosh@kernel.org>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help