Hello.

On 9/27/2015 1:29 PM, Thomas Gleixner wrote:

quoted

quoted

-	d = irq_find_matching_host(msi_np, DOMAIN_BUS_PLATFORM_MSI);
-	if (!d)
-		d = irq_find_host(msi_np);
-	dev_set_msi_domain(dev, d);
+		d = irq_find_matching_host(args.np, DOMAIN_BUS_PLATFORM_MSI);
+		if (!d)

		if (!d) {

quoted

+			d = irq_find_host(args.np);
+
+		if (d) {

		} else {

quoted

+			dev_set_msi_domain(dev, d);
+			return;
+		}

Errm, no. How is that equivalent?

Marc:

       d = foo();
       if (!d)
       	 d = bar();
       if (d) {
          bla(d);
	 return;
       }

Yours:

       d = foo();
       if (!d) {
       	 d = bar();
       } else {
          bla(d);
	 return;
       }

Hmm?

    Ah, sorry, didn't notice the kind of assignment in the first branch. :-<

Thanks,
	tglx

MBR, Sergei