[PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock'
From: Rafael J. Wysocki <hidden>
Date: 2015-09-25 20:05:14
Also in:
alsa-devel, linux-acpi, linux-bluetooth, linux-iommu, linux-mm, linux-scsi, linux-wireless, lkml, netdev
On Friday, September 25, 2015 10:26:22 PM Rafael J. Wysocki wrote:
On Friday, September 25, 2015 11:52:56 AM Viresh Kumar wrote:quoted
On 25-09-15, 20:49, Johannes Berg wrote:quoted
Ok, then, but that means Rafael is completely wrong ... debugfs_create_bool() takes a *pointer* and it needs to be long-lived, it can't be on the stack. You also don't get a call when it changes.Ahh, ofcourse. My bad as well...Well, sorry about the wrong suggestion.quoted
I think we can change structure definition but will wait for Rafael's comment before that.OK, change the structure then.
But here's a question. You're going to change that into bool in the next patch, right? So what if bool is a byte and the field is not word-aligned and changing that byte requires a read-modify-write. How do we ensure that things remain consistent in that case? Thanks, Rafael