On 25-09-15, 19:42, Johannes Berg wrote:

On Fri, 2015-09-25 at 09:41 -0700, Viresh Kumar wrote:

quoted

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
V3->V4:
- Create a local variable instead of changing type of global_lock
  (Rafael)

Err, surely that wasn't what Rafael meant, since it's clearly
impossible to use a pointer to the stack, assign to it once, and the
expect anything to wkr at all ...

Sorry, I am not sure on what wouldn't work with this patch but this is
what Rafael said, and I don't think I wrote it differently :)

Rafael wrote:

Actually, what about adding a local u32 variable, say val, here and doing

quoted

 	if (!debugfs_create_x32("gpe", 0444, dev_dir, (u32 *)&first_ec->gpe))
 		goto error;
 	if (!debugfs_create_bool("use_global_lock", 0444, dev_dir,
-				 (u32 *)&first_ec->global_lock))
+				 &first_ec->global_lock))

	if (!debugfs_create_bool("use_global_lock", 0444, dev_dir, &val))

quoted

 		goto error;

	first_ec->global_lock = val;

And then you can turn val into bool just fine without changing the structure
definition.

-- 
viresh