Thread (22 messages) 22 messages, 6 authors, 2015-09-21

[PATCH 1/7] phy: fix of_mdio_find_bus() device refcount leak

From: davem@davemloft.net (David Miller)
Date: 2015-09-21 19:02:06
Also in: linux-devicetree, linuxppc-dev, lkml, netdev

From: Russell King <redacted>
Date: Fri, 18 Sep 2015 10:54:55 +0100
Update the comment, and arrange for the only user of this function
to drop this refcount when disposing of a reference to it.
mdio_mux is not the only user of of_mdio_find_bus(), DSA uses it as
well.

So if anything this commit message is inaccurate.

I also wonder about this refcounting scheme.

If you are going to drop the inner device reference, then we take the
mdio bus returned from of_mdio_find_bus() what holds onto it and keeps
it from disappearing on us?

Don't we have to hold onto some reference count of some kind here?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help