Thread (18 messages) 18 messages, 6 authors, 2015-09-18

[PATCH 1/3] clocksource: rockchip: Make the driver more readability and compatible

From: Caesar Wang <hidden>
Date: 2015-09-17 09:28:37
Also in: linux-rockchip, lkml

Hi Daniel,


? 2015?09?17? 17:11, Daniel Lezcano ??:
Hi Caesar,


On 09/17/2015 09:51 AM, Caesar Wang wrote:
quoted
Build the arm64 SoCs (e.g.: RK3368) on Rockchip platform,
There are some failure with build up on timer driver for rockchip.

logs:
...
drivers/clocksource/rockchip_timer.c:156:13: error: 'NO_IRQ' undeclared
I think the NO_IRQ definition is missing for ARM64.
Yep, Maybe better to compatible if we don't use the 'NO_IRQ',
quoted
/tmp/ccdAnNy5.s:47: Error: missing immediate expression at  operand 1 --
`dsb`
...

The problem was different semantics of dsb on btw arm32 and arm64,
Here we can convert the dsb with insteading of dsb(sy).
What happens to ARM32 then ?
The dsb() is ok for ARM32, the ARM32/64 are OK if we can convert the 
dsb() to dsb(sy).
I believe all drivers with 'dsb()' have same issue on ARM64 platform.
quoted
Meanwhile, I change a bit to make the code more readability for driver
when I check the code style.

Signed-off-by: Caesar Wang <redacted>

-- 
Thanks,
Caesar
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help