Thread (15 messages) 15 messages, 4 authors, 2015-09-17

[PATCH v3 0/5] ACPI: Provide better MADT subtable sanity checks

From: Al Stone <hidden>
Date: 2015-09-16 19:26:36
Also in: linux-acpi, linux-pm, lkml

On 09/16/2015 10:27 AM, Al Stone wrote:
On 09/16/2015 10:24 AM, Al Stone wrote:
quoted
On 09/15/2015 08:44 PM, Rafael J. Wysocki wrote:
quoted
On Tuesday, September 15, 2015 03:13:12 PM Al Stone wrote:
quoted
On 09/09/2015 03:09 PM, Al Stone wrote:
quoted
Currently, the BAD_MADT_ENTRY macro is used to do a very simple sanity
check on the various subtables that are defined for the MADT.  The check
compares the size of the subtable data structure as defined by ACPICA to
the length entry in the subtable.  If they are not the same, the assumption
is that the subtable is incorrect.
[snip...]
quoted
quoted
I'm going to apply this series if people have no problems with it.  I do think
it is slightly overkill, but then as long as it works ...
Indeed it does.  We've found and fixed two MADTs with legitimate errors in them
with these patches (both arm64 tables still in development).
quoted
quoted
Thanks,
Rafael
Would you prefer I send out the updated version with Sudeep's fix to apply
instead of this version?  Or have you picked that up already?  Easily updated
and sent out, if it'll make your life simpler....
Bah.  Never mind.  An inadvertent use of the 01day builder by someone else
found another nit; I'll spin out a v4 later today just so everything is very
clear.

-- 
ciao,
al
-----------------------------------
Al Stone
Software Engineer
Red Hat, Inc.
ahs3 at redhat.com
-----------------------------------
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help