Thread (9 messages) flat view 9 messages, 4 authors, 2015-10-03

[PATCH v2] arm: Fix backtrace generation when IPI is masked

From: Russell King - ARM Linux <hidden>
Date: 2015-09-15 13:42:24
Also in: lkml

On Tue, Sep 15, 2015 at 02:15:10PM +0100, Daniel Thompson wrote:
Actually it already gets masked out. The argument to raise_nmi() points to a
data structure owned by the backtrace library functions and this structure
if altered during the execution of nmi_cpu_backtrace() to clear the calling
CPU.

I had originally planned to use cpumask_test_and_clear_cpu() for the
conditional branch but that would be broken because nmi_cpu_backtrace()
would become a nop if we clear anything from the mask before calling it!

I guess I should add a comment about this to save us from broken but
"obviously correct" cleanups in the future...
Absolutely.

-- 
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help