[PATCH v4 21/22] driver core: Start processing deferred probes earlier

From
Tomeu Vizoso <hidden>
Date
2015-09-15 13:16:36
Also in
linux-acpi, linux-devicetree, lkml
Reply to
Mark Brown, 2015-09-11
On 11 September 2015 at 14:24, Mark Brown [off-list ref] wrote:
On Mon, Sep 07, 2015 at 02:23:46PM +0200, Tomeu Vizoso wrote:
quoted
Some initcalls in the late level assume that some devices will have
already probed without explicitly checking for that.

After the recent move to defer most device probes when they are
registered, pressure increased in the late initcall level.

By starting the processing of the deferred queue in device_initcall_sync
we increase the chances that the initcalls mentioned before will find
the devices they depend on to have already probed.
Which cases do we have that are outside the driver model and thus
affected by this?  USB gadgets are one case I'm aware of, and cpufreq is
still problematic.  I'm wondering if it might be tractable to address
the actual problems with the remaining reliance on init ordering here.
Actually, I don't know of any specific case that needs this commit.
The present series without this patch passes on all the boards in
kernelci, but Grygorii Strashko argued for it during the review of the
earlier version of this series:
http://lkml.kernel.org/g/55CE3D04.8000607 at ti.com

IMO it would be better to not apply this patch until the need arises,
and even then, it may be better to make the dependencies explicit
instead of relying on implicit ordering and messing with the link
order.
I'm also wondering if we might end up running into situations where this
makes the problem with havinng to defer probes more of an issue on some
systems - since we start trying earlier while we are still doing our
first pass initialisation we could end up deferring some device then
retrying it a bunch of times while going through the earlier phases of
init as we continue to register more devices.
With the rest of the series this shouldn't happen as all/most deferred
probes should be avoided.

Regards,

Tomeu
Thread (43 messages) 43 messages, 7 authors, last reply 2015-10-21
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help