Thread (13 messages) 13 messages, 7 authors, 2015-09-11

[PATCH 1/3] doc: dt: add documentation for Mediatek spi-nor controller

From: computersforpeace@gmail.com (Brian Norris)
Date: 2015-09-11 21:49:12
Also in: linux-devicetree, linux-mediatek, lkml

One more thing:

On Tue, Sep 08, 2015 at 05:49:54PM +0800, Bayi Cheng wrote:
+- clocks: spi nor source clock
^^ you only list one clock here
+- clock-names: "spi_clk", "axi_clk", "mux_clk", "sf_clk"
But you have 4 names here.

...
+	clocks = <&pericfg CLK_PERI_SPI>,
+		 <&topckgen CLK_TOP_AXI_SEL>,
+		 <&topckgen CLK_TOP_UNIVPLL2_D8>,
+		 <&topckgen CLK_TOP_SPINFI_IFR_SEL>;
And you provide 4 clocks.
+	clock-names = "spi_clk", "axi_clk", "mux_clk", "sf_clk";
Please list all 4 under the "clocks" property, not just under the
"clock-names" property.

Brian
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help