[PATCH 7/9] arm: twr-k70f120m: IOMUX driver for Kinetis SoC
From: Paul Osmialowski <hidden>
Date: 2015-09-08 08:27:47
Also in:
linux-clk, linux-devicetree, linux-gpio, lkml
Hi Linus, On Tue, 14 Jul 2015, Linus Walleij wrote:
OK... I want Shawn and Sascha to look at this as they worked with other Freescale pin controllers. Especially I want to know if this is a sibling to the other Freescale controllers or a separate hardware. If it is *not* a sibling I will *insist* that it use more generic pin control bindings and move away from the older Freescale-specific stuff.
No one answered me about that. However, I looked at other Freescale pinctrl drivers and realised that no one of them (IMX, IMX1, MXS) is similar to what I need to do for Kinetis, also positions of configuration bits differ significantly.
There exist generic pin config bindings, see Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt I suggest to to function+group paring and then use generic pin config with this driver unless it is a very close sibling to the existing Freescale pin controllers. Hint: if it is a sibling, it should share code with them. There are several drivers doing generic pin control/pin config in the kernel tree.
I tried to analyze few of the drivers (e.g. zynq family) and can't find how can I assing clock gate (clock device) to each port (PORTA, PORTB, PORTC,...) which is required for Kinetis. Is generic pin control capable to express that requirement or is it a time to desing my own pinctrl driver (maybe somewhat improved than the one I presented so far)? This pinctrl component is somwehat critical part of BSP. Until it is not sorted, I don't see a point in releasing what was developed so far. Best regards, Paul