Thread (5 messages) flat view 5 messages, 4 authors, 2015-08-24
STALE4010d

[PATCH v2 09/21] ARM: pxa: magician: Add OV9640 camera support

From: Petr Cvek <hidden>
Date: 2015-08-20 22:39:30
Also in: linux-leds, linux-pm

Dne 20.8.2015 v 22:26 Arnd Bergmann napsal(a):
On Thursday 20 August 2015 21:48:20 Robert Jarzmik wrote:
quoted
Petr Cvek [off-list ref] writes:
quoted
+     mdelay(3);
Okay, there are several mdelay(3) in this file.

Could you please test if removing these mdelays prevents the camera from working
? If not, I'd like to have them removed.
FWIW, it might be possible to replace some of them with msleep() calls,
potentially after replacing spinlocks with mutexes where necessary.

	Arnd
Datasheet says:

	tS:RESET	Setting time after software/hardware reset	1 ms

So at least one ~1 ms should be left there. Are msleep less than 20ms valid? 

(checkpatch: msleep < 20ms  can sleep for up to 20ms)

Petr
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help