[PATCH 1/2] drivers: PL061: add support for platform driver probing
From: Russell King - ARM Linux <hidden>
Date: 2015-08-03 19:07:00
On Mon, Aug 03, 2015 at 04:13:31PM +0100, Graeme Gregory wrote:
On Mon, 3 Aug 2015, at 01:40 PM, Linus Walleij wrote:quoted
On Mon, Aug 3, 2015 at 8:59 AM, Shannon Zhao [off-list ref] wrote:quoted
From: Shannon Zhao <redacted> Since PL061 currently only supports AMBA driver, to support using GPIO PL061 by DT or ACPI, it needs to add support for platform driver. A DT binding is provided with this patch, ACPI support is added in a separate one. Signed-off-by: Shannon Zhao <redacted> Signed-off-by: Shannon Zhao <redacted>I already stated in 0/2 what the problem is with this, and it's obviously adding a huge codechunk, very similar to the AMBA probe path. We need to investigate if ACPI can just spawn AMBA/PrimeCell type devices instead.AMBA DT support is a hideous hack, we had kind of hoped to avoid doing that in ACPI. If you notice ARM already updated pl011 driver to support platform device type probing this seems to be the way to go.
As the AMBA bus maintainer, NAK on that. -- FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up according to speedtest.net.