Thread (21 messages) 21 messages, 4 authors, 2015-09-23

[PATCH 1/6] gpiolib-of: Rename gpio_hog functions to be generic

From: Linus Walleij <hidden>
Date: 2015-08-10 09:29:59
Also in: linux-gpio

On Tue, Aug 4, 2015 at 11:23 AM, Markus Pargmann [off-list ref] wrote:
The gpio hogging functions are currently only used for gpio-hogging. But
these functions are widely generic ones which parse gpio device nodes in
the DT.

Signed-off-by: Markus Pargmann <redacted>
(...)
 /**
- * of_get_gpio_hog() - Get a GPIO hog descriptor, names and flags for GPIO API
+ * of_parse_gpio() - Get a GPIO hog descriptor, names and flags for GPIO API
It's not a good name, too generic. It could easily be assued this is
for something
wider.

of_parse_own_gpio() or something, indicating that this pertains to the
chip itself and not to outside users, would be better.

Yours,
Linus Walleij
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help