[PATCH 2/3] nvmem: imx-ocotp: Add i.MX6 OCOTP driver

Am Donnerstag, den 06.08.2015, 20:36 +0100 schrieb Srinivas Kandagatla:

Hi Philipp,

Could you add Greg KH in the CC, for next merge window, we can request 
Greg to take this driver via his tree.

Once the comments are fixed you can add my

Acked-by: Srinivas Kandagatla <redacted>

On 06/08/15 17:28, Philipp Zabel wrote:

quoted

Hi Srinivas,

Am Donnerstag, den 06.08.2015, 17:20 +0100 schrieb Srinivas Kandagatla:

quoted

Few Nits..

On 04/08/15 14:02, Philipp Zabel wrote:

quoted

+#include <linux/clk.h>

May be you can drop this?

Yes, that's a left-over and can be removed.

quoted

BTW, who is taking care of the gated peripheral clock controlled for
this driver?

Nobody. I had initially copied the code that actually senses the fuses,
but since this happens during power-on reset anyway (all values are
stored in shadow registers), I didn't see the point and dropped it for
now.
The shadow registers are clocked directly by the ungated ipg_root clock.

So, are you planning to drop the clocks property from the bindings too?

The gated clock input exists and is needed for the full functionality of
the device (writing and re-sensing fuses). It should be in the device
tree even if the linux driver doesn't implement writing.

regards
Philipp