Thread (7 messages) 7 messages, 3 authors, 2015-08-20

[PATCH] arm64: entry: always restore x0 from the stack on syscall return

From: catalin.marinas@arm.com (Catalin Marinas)
Date: 2015-08-19 16:03:24
Also in: stable

On Wed, Aug 19, 2015 at 04:09:49PM +0100, Will Deacon wrote:
quoted hunk ↗ jump to hunk
@@ -613,13 +609,14 @@ ENDPROC(cpu_switch_to)
  */
 ret_fast_syscall:
 	disable_irq				// disable interrupts
+	str	x0, [sp, #S_X0]			// returned x0
 	ldr	x1, [tsk, #TI_FLAGS]		// re-check for syscall tracing
 	and	x2, x1, #_TIF_SYSCALL_WORK
 	cbnz	x2, ret_fast_syscall_trace
 	and	x2, x1, #_TIF_WORK_MASK
-	cbnz	x2, fast_work_pending
+	cbnz	x2, work_pending
 	enable_step_tsk x1, x2
-	kernel_exit 0, ret = 1
+	kernel_exit 0
 ret_fast_syscall_trace:
 	enable_irq				// enable interrupts
 	b	__sys_trace_return
There is another str x0 in __sys_trace_return which I think we could
remove.

-- 
Catalin
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help