On Tue, 25 Aug 2015, Vaibhav Hiremath wrote:

On Tuesday 25 August 2015 01:22 PM, Lee Jones wrote:

quoted

On Tue, 25 Aug 2015, Vaibhav Hiremath wrote:

quoted

Driver had coding style issues where spaces were used instead
of tabs. This patch fixes them all.

Signed-off-by: Vaibhav Hiremath <redacted>
---
 drivers/mfd/88pm800.c | 125 ++++++++++++++++++++++++--------------------------
 1 file changed, 61 insertions(+), 64 deletions(-)

Same comment as before.

How similar is this file to the other one?

I believe you are referring to include/linux/mfd/88pm80x.h

quoted

Can you reduce the size by having shared register defines?

Not sure whether I understand your comment here,
They are common defines.

I guess the question was a little convoluted.

How about; why are the extra defines in the driver?  Why aren't all of
them in the header file?  What is the difference between the defines
in the C file compared with the ones defined in the header?

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog