Thread (44 messages) 44 messages, 10 authors, 2015-08-25

[PATCH v3 06/14] Documentation: drm/bridge: add document for analogix_dp

From: Yakir Yang <hidden>
Date: 2015-08-25 01:22:13
Also in: dri-devel, linux-devicetree, linux-rockchip, linux-samsung-soc, lkml


? 2015/8/24 22:48, Rob Herring ??:
On Mon, Aug 24, 2015 at 7:57 AM, Russell King - ARM Linux
[off-list ref] wrote:
quoted
On Sun, Aug 23, 2015 at 06:23:14PM -0500, Rob Herring wrote:
quoted
On Wed, Aug 19, 2015 at 9:50 AM, Yakir Yang [off-list ref] wrote:
quoted
+       -analogix,color-depth:
+               number of bits per colour component.
+                       COLOR_6 = 0, COLOR_8 = 1, COLOR_10 = 2, COLOR_12 = 3
This seems pretty generic. Just use 6, 8, 10, or 12 for values. And
drop the vendor prefix.
Please think about this some more.  What does "color-depth" mean?  Does it
mean the number of bits per colour _component_, or does it mean the total
number of bits to represent a particular colour.  It's confusing as it
stands.
Then "component-color-bpp" perhaps?
Actually this "color-bpp" should come from crtc driver, maybe should 
come from
"struct drm_crtc {".

Like rockchip stuffs, analogix_dp-rockchip call an mode_config from 
rockchip_drm_vop
driver and set output mode to RGB[10:10:10], then vop driver just store 
the output mode
type to the private struct "vop->connecot_out_mode". do think that this 
outmode should
store into crtc, not just come from DT prop.

- Yakir
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help