Thread (30 messages) 30 messages, 10 authors, 2015-08-25

[PATCH 00/18] ARM: use const and __initconst for smp_operations

From: Olof Johansson <hidden>
Date: 2015-08-24 21:44:25
Also in: linux-arm-msm, linux-rockchip, linux-samsung-soc, lkml

On Mon, Aug 24, 2015 at 2:21 PM, Russell King - ARM Linux
[off-list ref] wrote:
On Mon, Aug 24, 2015 at 02:12:06PM -0700, Olof Johansson wrote:
quoted
Easiest of all would probably be to get the sub-arch patches into one
release, then switch the prototypes and function definitions in the
next. If you switch prototypes first you'll get a bunch of warnings,
right?
Wrong way around. :)

If you change the sub-arches to declare the smp operations as const,
and try and pass them into a function which doesn't take a const-pointer,
you'll get a warning.  The core bits need to go in first before the
sub-arch patches.
Ah yes, my bad.
I think the series has limited value - it allows us to (a) check that a
small quantity of code doesn't write to these things, and (b) allows us
to move the SMP operations structure from __initdata to __initconstdata.
It's still going to end up in the init region which is read/write in any
case, and still gets thrown away.

Given where we are, I don't think we need to rush this in during the
last week before the merge window opens, even though it's trivial.
Agreed. So if you pick it up for 4.4, we'll get the rest for 4.5.


-Olof
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help