Thread (63 messages) 63 messages, 5 authors, 2015-09-01

[Xen-devel] [PATCH v3 11/20] tty/hvc: xen: Use xen page definition

From: David Vrabel <hidden>
Date: 2015-08-20 09:56:20
Also in: linuxppc-dev, lkml

On 07/08/15 17:46, Julien Grall wrote:
The console ring is always based on the page granularity of Xen.
[...]
quoted hunk ↗ jump to hunk
--- a/drivers/tty/hvc/hvc_xen.c
+++ b/drivers/tty/hvc/hvc_xen.c
@@ -230,7 +230,7 @@ static int xen_hvm_console_init(void)
 	if (r < 0 || v == 0)
 		goto err;
 	gfn = v;
-	info->intf = xen_remap(gfn << PAGE_SHIFT, PAGE_SIZE);
+	info->intf = xen_remap(gfn << XEN_PAGE_SHIFT, PAGE_SIZE);
You need XEN_PAGE_SIZE here I think...
quoted hunk ↗ jump to hunk
 	if (info->intf == NULL)
 		goto err;
 	info->vtermno = HVC_COOKIE;
@@ -472,7 +472,7 @@ static int xencons_resume(struct xenbus_device *dev)
 	struct xencons_info *info = dev_get_drvdata(&dev->dev);
 
 	xencons_disconnect_backend(info);
-	memset(info->intf, 0, PAGE_SIZE);
+	memset(info->intf, 0, XEN_PAGE_SIZE);
...particularly since you use it here.

David
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help