Thread (11 messages) 11 messages, 6 authors, 2015-07-02
DORMANTno replies

[PATCH] ARM: psci: boot_secondary: replace __pa with virt_to_idmap

From: mark.rutland@arm.com (Mark Rutland)
Date: 2015-07-02 10:55:39

quoted
I could retain the struct and packing functions for the two cases you
mention, but it seemed somewhat misleading. I'll see if I can figure out
something better than a raw hex value.
What's wrong with a few #defines for this?
Nothing.
It obviously is well enough defined in existing pre-v1.0
implementations as there is an existing structure to the parameter.

Can we not do something like:

#define PSCI_POWER_STATE_ID(x)			(x)
#define PSCI_POWER_STATE_TYPE_POWER_DOWN	0x000100000
#define PSCI_POWER_STATE_AFFINITY_LEVEL(x)	((x) << 24)
Looks good.

We already have some constants defined in a UAPI header, so I'll see
about reusing those.

Thanks,
Mark.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help