On 07/23/2015 02:09 AM, Stanimir Varbanov wrote:

<snip>

quoted

+
+void gdsc_unregister(struct device *dev)
+{
+    of_genpd_del_provider(dev->of_node);
+}
EXPORT_SYMBOL?

Stephen, gdsc_register/unregister are internal to the qcom clk driver
why to export them?

Ah, I thought this was being called from outside the clk-qcom.ko module. 
As long as we don't call them from a SoC specific driver then it should 
be ok to leave them unexported. Perhaps we should remove the export on 
qcom_find_freq() too?

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project