Thread (1 message) 1 message, 1 author, 2015-07-29

[PATCH 02/10] usb: chipidea: define stream mode disable for both roles

From: Peter Chen <hidden>
Date: 2015-07-29 04:41:29
Also in: linux-devicetree

On Tue, Jul 28, 2015 at 10:10:16PM -0700, Greg KH wrote:
On Wed, Jul 29, 2015 at 10:42:06AM +0800, Peter Chen wrote:
quoted
@@ -20,7 +20,6 @@ struct ci_hdrc_platform_data {
 	unsigned long	 flags;
 #define CI_HDRC_REGS_SHARED		BIT(0)
 #define CI_HDRC_SUPPORTS_RUNTIME_PM	BIT(2)
-#define CI_HDRC_DISABLE_STREAMING	BIT(3)
Why not just rename this one, now you have a "hole" in your bit field
that people aren't going to know if they can use or not.
I will change it, thanks.

-- 

Best Regards,
Peter Chen
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help