[PATCH V3 04/19] memory: tegra: add flush operation for Tegra114 memory clients
From: Thierry Reding <hidden>
Date: 2015-07-17 10:05:13
Also in:
linux-devicetree, linux-pm, linux-tegra
On Mon, Jul 13, 2015 at 01:39:42PM +0100, Jon Hunter wrote:
quoted hunk
From: Vince Hsu <redacted> This patch adds the hot reset register table and flush related callback functions for Tegra114. Signed-off-by: Vince Hsu <redacted> [jonathanh at nvidia.com: Removed tegra_mc_ops and added metastable_flush_reads.] Signed-off-by: Jon Hunter <jonathanh@nvidia.com> --- drivers/memory/tegra/tegra114.c | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+)diff --git a/drivers/memory/tegra/tegra114.c b/drivers/memory/tegra/tegra114.c index 9f579589e800..ba33c402ed68 100644 --- a/drivers/memory/tegra/tegra114.c +++ b/drivers/memory/tegra/tegra114.c@@ -914,6 +914,24 @@ static const struct tegra_smmu_swgroup tegra114_swgroups[] = { { .name = "tsec", .swgroup = TEGRA_SWGROUP_TSEC, .reg = 0x294 }, }; +static struct tegra_mc_flush tegra114_mc_flush[] = {
const
+ {TEGRA_SWGROUP_AVPC, 0x200, 0x204, 1},
+ {TEGRA_SWGROUP_DC, 0x200, 0x204, 2},
+ {TEGRA_SWGROUP_DCB, 0x200, 0x204, 3},
+ {TEGRA_SWGROUP_EPP, 0x200, 0x204, 4},
+ {TEGRA_SWGROUP_G2, 0x200, 0x204, 5},
+ {TEGRA_SWGROUP_HC, 0x200, 0x204, 6},
+ {TEGRA_SWGROUP_HDA, 0x200, 0x204, 7},
+ {TEGRA_SWGROUP_ISP, 0x200, 0x204, 8},
+ {TEGRA_SWGROUP_MPCORE, 0x200, 0x204, 9},
+ {TEGRA_SWGROUP_MPCORELP, 0x200, 0x204, 10},
+ {TEGRA_SWGROUP_MSENC, 0x200, 0x204, 11},
+ {TEGRA_SWGROUP_NV, 0x200, 0x204, 12},
+ {TEGRA_SWGROUP_PPCS, 0x200, 0x204, 14},
+ {TEGRA_SWGROUP_VDE, 0x200, 0x204, 16},
+ {TEGRA_SWGROUP_VI, 0x200, 0x204, 17},
+};
And spaces after { and before }.
quoted hunk
+ static void tegra114_flush_dcache(struct page *page, unsigned long offset, size_t size) {@@ -945,4 +963,7 @@ const struct tegra_mc_soc tegra114_mc_soc = { .num_address_bits = 32, .atom_size = 32, .smmu = &tegra114_smmu_soc, + .flushes = tegra114_mc_flush, + .num_flushes = ARRAY_SIZE(tegra114_mc_flush), + .metastable_flush_reads = MC_FLUSH_METASTABLE_READS,
I don't think it's useful to have this define. Just use the literal value here. Much of the purpose of having this per-SoC parameter is to provide the context that otherwise the macro symbol would provide. Thierry -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150717/397468ae/attachment.sig>