[PATCH v1 3/4] Crypto: Add support for APM X-Gene SoC CRC32C h/w accelerator driver
flat view
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2015-07-31 07:14:22
Also in:
linux-crypto, linux-devicetree, lkml
On Thu, Jul 30, 2015 at 05:41:07PM +0530, Rameshwar Prasad Sahu wrote:
+ .cra_name = "xgene(crc32c)", + .cra_driver_name = "crc32c-xgene",
This looks wrong. If you're implementing crc32c then cra_name should be just crc32c, i.e., the name of the algorithm that you are providing.
quoted hunk ↗ jump to hunk
+MODULE_DESCRIPTION("APM X-Gene SoC CRC32C HW accelerator driver"); +MODULE_AUTHOR("Rameshwar Prasad Sahu <rsahu@apm.com>"); +MODULE_LICENSE("GPL"); +MODULE_VERSION("1.0");
You should add a MODULE_ALIAS_CRYPTO too. Cheers, -- Email: Herbert Xu [off-list ref] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt