Thread (39 messages) 39 messages, 4 authors, 2015-08-09

[PATCH v2 01/22] platform: delay device-driver matches until late_initcall

From: Rob Herring <hidden>
Date: 2015-07-30 03:20:28
Also in: linux-acpi, linux-devicetree, lkml

On Tue, Jul 28, 2015 at 8:19 AM, Tomeu Vizoso
[off-list ref] wrote:
quoted hunk ↗ jump to hunk
Delay matches of platform devices until late_initcall, when we are sure
that all built-in drivers have been registered already.  This is needed
to prevent deferred probes because of some drivers not having registered
yet.

The reason why only platform devices are delayed is that some other
devices are expected to be probed earlier than late_initcall, for
example, the system PNP driver needs to probe its devices in
fs_initcall.

Signed-off-by: Tomeu Vizoso <redacted>
---

Changes in v2:
- Move delay to platform.c

 drivers/base/platform.c | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)
diff --git a/drivers/base/platform.c b/drivers/base/platform.c
index 063f0ab15259..fcf654678e27 100644
--- a/drivers/base/platform.c
+++ b/drivers/base/platform.c
@@ -33,6 +33,8 @@
 /* For automatically allocated device IDs */
 static DEFINE_IDA(platform_devid_ida);

+static bool enable_matches;
+
 struct device platform_bus = {
        .init_name      = "platform",
 };
@@ -839,6 +841,15 @@ static int platform_match(struct device *dev, struct device_driver *drv)
        struct platform_device *pdev = to_platform_device(dev);
        struct platform_driver *pdrv = to_platform_driver(drv);

+       /*
+        * Delay matches of platform devices until late_initcall, when we are
+        * sure that all built-in drivers have been registered already. This
+        * is needed to prevent deferred probes because of some drivers
+        * not having registered yet.
+        */
+       if (!enable_matches)
+               return false;
+
Having this as a global makes me nervous. I think it would be better
to be DT specific or per device some how. Perhaps use OF_POPULATED_BUS
flag as an additional test.

There could be non-DT platforms that rely on the initcall ordering and
moving all probes to late_initcall could change the ordering. I'm not
sure though.

Rob
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help