[RESEND PATCH] pinctrl: at91: fix null pointer dereference
From: Linus Walleij <hidden>
Date: 2015-07-28 12:48:12
Also in:
linux-gpio, lkml
From: Linus Walleij <hidden>
Date: 2015-07-28 12:48:12
Also in:
linux-gpio, lkml
On Tue, Jul 28, 2015 at 9:48 AM, Ludovic Desroches [off-list ref] wrote:
From: David Dueck <redacted> Not all gpio banks are necessarily enabled, in the current code this can lead to null pointer dereferences. [ 51.130000] Unable to handle kernel NULL pointer dereference at virtual address 00000058
(...)
Signed-off-by: David Dueck <redacted> Acked-by: Ludovic Desroches <redacted> Acked-by: Alexandre Belloni <redacted> CC: Nicolas Ferre <redacted> CC: Boris Brezillon <redacted> CC: linux-arm-kernel at lists.infradead.org CC: linux-kernel at vger.kernel.org --- This patch fixes a oops in the kernel because of a NULL pointer in a table. Having a NULL pointer in this table is the normal behavior if a PIO controller is not enabled. So this fix is not a quick and dirty hack, it's usual to skip an entry from a table if it is not filled.
Fair enough, better too many checks than too few. Is this a regression to v4.2 that should go to stable or v4.3 material? Yours, Linus Walleij