On 07/20/2015 08:12 PM, Timur Tabi wrote:

Hanjun Guo wrote:

quoted

quoted

Should we display an error message if we don't find a matching table?
That can happen if the ACPI tables shows a GIC version number that is
not listed in __irqchip_acpi_table[]?

Hmm, did you get the error message like: "Invalid GIC version 5 in
MADT"? or just use ACPI_MADT_GIC_VERSION_V1 as the gic_version? if
the later one, it will show everything is fine, but failed to probe
the GIC.

We had a bug in our ACPI tables that listed the GIC version as 1, and it
failed to probe and then the kernel panicked.  It took me a while to
figure out what was wrong, so I think it should print an error message
that says that version X is unsupported.

OK, will do in next version, thanks for testing those patches!

Hanjun