Thread (7 messages) 7 messages, 4 authors, 2015-07-20

[PATCH v3] serial: mxs-auart: keep the AUART unit in reset state when not in use

From: Stefan Wahren <hidden>
Date: 2015-07-16 15:36:55
Also in: linux-serial, lkml

Whenever the UART device driver gets closed from userland, the driver
disables the UART unit and then stops its clock to save power.

The bit which disabled the UART unit is described as:

  "UART Enable. If this bit is set to 1, the UART is enabled. Data
  transmission and reception occurs for the UART signals. When the
  UART is disabled in the middle of transmission or reception, it
  completes the current character before stopping."

The important part is the "it completes the current character". Whenever
a reception is ongoing when the UART gets disabled (including the clock
off) the statemachine freezes and "remembers" this state on the next
open() and re-enabling of the unit's clock.

In this case we end up receiving an additional bogus character
immediately.

The solution in this change is to move the AUART unit into its reset
state on close() and only release it from its reset state on the next
open().

Signed-off-by: Juergen Borleis <redacted>
---
Acked-by: Stefan Wahren <redacted>

Thanks
Stefan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help