[PATCH] Input: pmic8xxx-pwrkey - Support shutdown
From: Bjorn Andersson <hidden>
Date: 2015-07-13 23:13:34
Also in:
linux-arm-msm, linux-input, lkml
On Mon 06 Jul 18:08 PDT 2015, Stephen Boyd wrote:
quoted hunk ↗ jump to hunk
On pm8xxx PMICs, shutdown and restart are signaled to the PMIC via a pin called PS_HOLD. When this pin goes low, the PMIC performs a configurable power sequence. Add a .shutdown hook so that we can properly configure this power sequence for shutdown or restart depending on the system state. Signed-off-by: Stephen Boyd <redacted> --- drivers/input/misc/pmic8xxx-pwrkey.c | 287 ++++++++++++++++++++++++++++++++++- 1 file changed, 280 insertions(+), 7 deletions(-)diff --git a/drivers/input/misc/pmic8xxx-pwrkey.c b/drivers/input/misc/pmic8xxx-pwrkey.c
[..]
/** * struct pmic8xxx_pwrkey - pmic8xxx pwrkey information * @key_press_irq: key press irq number + * @regmap: device regmap
Please also document the shutdown_fn.
*/
struct pmic8xxx_pwrkey {
int key_press_irq;
+ struct regmap *regmap;
+ int (*shutdown_fn)(struct pmic8xxx_pwrkey *, bool);
+};
+
+struct pm8xxx_nbs {
+ int (*shutdown_fn)(struct pmic8xxx_pwrkey *, bool);
};This struct is unused. [..]
static struct platform_driver pmic8xxx_pwrkey_driver = {
.probe = pmic8xxx_pwrkey_probe,
.remove = pmic8xxx_pwrkey_remove,
+ .shutdown = pmic8xxx_pwrkey_shutdown,I tried to find pros/cons of using this approach instead of register a reboot notifier like I did in the pm8941 driver, but I haven't come up with any good reason to pick one or the other.
.driver = {
.name = "pm8xxx-pwrkey",
.pm = &pm8xxx_pwr_key_pm_ops,With above nits I think this looks good. Regards, Bjorn