[PATCH v3 1/4] gpio: brcmstb: fix null ptr dereference in driver remove
From: Linus Walleij <hidden>
Date: 2015-07-13 12:24:15
Also in:
linux-devicetree, linux-gpio, lkml
From: Linus Walleij <hidden>
Date: 2015-07-13 12:24:15
Also in:
linux-devicetree, linux-gpio, lkml
On Thu, Jun 18, 2015 at 3:00 AM, Gregory Fong [off-list ref] wrote:
If a failure occurs during probe, brcmstb_gpio_remove() is called. In remove, we call platform_get_drvdata(), but at the time of failure in the probe the driver data hadn't yet been set which leads to a NULL ptr dereference in the remove's list_for_each. Call platform_set_drvdata() and set up list head right after allocating the priv struct to both avoid the null pointer dereference that could occur today. To guard against potential future changes, check for null pointer in remove. Reported-by: Tim Ross <redacted> Signed-off-by: Gregory Fong <redacted> --- New in v3.
Patch applied. Yours, Linus Walleij