On Thursday 25 June 2015 01:16 PM, Vaibhav Hiremath wrote:

On Saturday 20 June 2015 06:13 AM, Alexandre Belloni wrote:

quoted

Hi,

Sorry I missed this email.
Just wanted to send reminder email and saw this :)

quoted

On 18/06/2015 at 00:28:06 +0530, Vaibhav Hiremath wrote :

quoted

-    pdata = dev_get_platdata(&pdev->dev);
-    if (pdata == NULL)
-        dev_warn(&pdev->dev, "No platform data!\n");
+    if (!pdata && !node) {
+        dev_err(&pdev->dev,
+            "pm80x-rtc requires platform data or of_node\n");
+        return -EINVAL;
+    }
+
+    if (!pdata) {
+        pdata = devm_kzalloc(&pdev->dev, sizeof(*pdata), GFP_KERNEL);

I had troubles to follow the rtc_wakeup initialization cleanup but it
seems OK.

Probably, once we have complete PM support ready then it would be
easier to understand. I think as of now lets have this minimal code for
rtc_wakeup.

quoted

However, I'm wondering why you are adding DT support as this
will always be probed from the MFD driver which pass the platform_data
and avoids that allocation.

You are right.

Originally, it was cleanup patch,

  - remove pm80x_pdata
  - Add check for pdata and np
  - and around rtc_wakeup

While doing that I added this nice to have allocation.

Any update/feedback on this?

Thanks,
Vaibhav