Thread (7 messages) 7 messages, 7 authors, 2015-07-08

[PATCH] thermal: consistently use int for temperatures

From: heiko@sntech.de (Heiko Stübner)
Date: 2015-07-06 19:08:09
Also in: linux-acpi, linux-omap, linux-pm, linux-samsung-soc, lkml, platform-driver-x86

Am Montag, 6. Juli 2015, 09:19:49 schrieb Sascha Hauer:
The thermal code uses int, long and unsigned long for temperatures
in different places.

Using an unsigned type limits the thermal framework to positive
temperatures without need. Also several drivers currently will report
temperatures near UINT_MAX for temperatures below 0?C. This will probably
immediately shut the machine down due to overtemperature if started below
0?C.

'long' is 64bit on several architectures. This is not needed since INT_MAX
?mC is above the melting point of all known materials.

Consistently use a plain 'int' for temperatures throughout the thermal code
and the drivers. This only changes the places in the drivers where the
temperature is passed around as pointer, when drivers internally use
another type this is not changed.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Zhang Rui <rui.zhang@intel.com>
Cc: Eduardo Valentin <edubezval@gmail.com>
Cc: linux-pm at vger.kernel.org
Cc: linux-kernel at vger.kernel.org
Cc: Jean Delvare <redacted>
Cc: Peter Feuerer <peter@piie.net>
Cc: Heiko Stuebner <heiko@sntech.de>
Cc: Lukasz Majewski <redacted>
Cc: Stephen Warren <redacted>
Cc: Thierry Reding <redacted>
Cc: linux-acpi at vger.kernel.org
Cc: platform-driver-x86 at vger.kernel.org
Cc: linux-arm-kernel at lists.infradead.org
Cc: linux-omap at vger.kernel.org
Cc: linux-samsung-soc at vger.kernel.org
Cc: Guenter Roeck <linux@roeck-us.net>
Cc: Rafael J. Wysocki <redacted>
Cc: Maxime Ripard <redacted>
Cc: Darren Hart <dvhart@infradead.org>
Cc: lm-sensors at lm-sensors.org
---
For
 drivers/thermal/rockchip_thermal.c                 | 10 ++++----
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help