[PATCH v3 2/4] tty/serial: at91: fix some macro definitions to fit coding style
From: Cyrille Pitchen <hidden>
Date: 2015-07-02 13:37:04
Also in:
linux-devicetree, linux-serial, lkml
From: Cyrille Pitchen <hidden>
Date: 2015-07-02 13:37:04
Also in:
linux-devicetree, linux-serial, lkml
Hi Arnd, I've just sent a new series of patches to remove all those macros. By the way, the patch dedicated to this update was created using coccinelle. Based on Alexandre comment, I leave __raw_writel() and __raw_readl() for now. Best Regards, Cyrille Le 30/06/2015 22:28, Arnd Bergmann a ?crit :
On Tuesday 30 June 2015 16:05:15 Cyrille Pitchen wrote:quoted
+#define UART_PUT_CR(port, v) __raw_writel(v, (port)->membase + ATMEL_US_CR) +#define UART_GET_MR(port) __raw_readl((port)->membase + ATMEL_US_MR) +#define UART_PUT_MR(port, v) __raw_writel(v, (port)->membase + ATMEL_US_MR) +#define UART_PUT_IER(port, v) __raw_writel(v, (port)->membase + ATMEL_US_IER)How about removing these macros entirely? I'm not aware of other drivers doing it like this, and it does not seem to add any value? At the same time, you could use readl_relaxed() to make the driver endian-safe. Arnd