Hi Mike,

On 18/06/2015 20:36, Michael Turquette wrote:

Quoting Gregory CLEMENT (2015-06-17 04:57:08)

quoted

Hi Mike, Stephen,

On 16/06/2015 17:56, Boris Brezillon wrote:

quoted

The crypto SRAM, used by the armada 370 cpuidle code to workaround a bug
in the BootROM code, requires the crypto clk to be up and running.
Flag the crypto clk as IGNORE_UNUSED until we add the proper
infrastructure to define the crypto SRAM in the DT and reference the crypto
clk in this SRAM node.

Reported-by: Kevin Hilman <redacted>
Signed-off-by: Boris Brezillon <redacted>
Tested-by: Kevin Hilman <redacted>
Fixes: 29e623475c50267ee3aaa49ebb6cbe107bce8d2a ("clk: mvebu: add
missing CESA gate clk").
Cc: <redacted> #4.1

Acked-by: Gregory CLEMENT <redacted>

Would it possible to apply this fix on 4.1-rc8 ?

Hi Gregory,

I'm a bit confused by this. This patch fixes "clk: mvebu: add missing
CESA gate clk", right? That patch lives in clk-next. It was not pushed
to Linus' tree yet via a -fixes branch.

Thus I can just apply this patch to clk-next and the problem should be
resolved in clk-next, no?

You're right I was confused by the "[off-list ref] #4.1" tag,
and I thought it was already part of 4.1. So indeed you just have to apply
it in clk-next. You can remove the Fixes: and CC: line. And even better
you can squashed it into 4d52b2acefdf "clk: mvebu: add missing CESA
gate clk", if your clk-next branch is not immutable.

Furthermore, I do not have 29e623475c50267ee3aaa49ebb6cbe107bce8d2a
anywhere in my tree. I'm not sure where this sha1 hash came from.

Me neither :)


Thanks,

Gregory

quoted

quoted

---
Changes since v1:
- add the Reported-by tag
- add the missing trailing ','

 drivers/clk/mvebu/armada-370.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/mvebu/armada-370.c b/drivers/clk/mvebu/armada-370.c
index c19fd77..2c7c108 100644
--- a/drivers/clk/mvebu/armada-370.c
+++ b/drivers/clk/mvebu/armada-370.c

@@ -163,7 +163,7 @@ static const struct clk_gating_soc_desc a370_gating_desc[] __initconst = {
      { "pex1", "pex1_en", 9, 0 },
      { "sata0", NULL, 15, 0 },
      { "sdio", NULL, 17, 0 },
-     { "crypto", NULL, 23, 0 },
+     { "crypto", NULL, 23, CLK_IGNORE_UNUSED },
      { "tdm", NULL, 25, 0 },
      { "ddr", NULL, 28, CLK_IGNORE_UNUSED },
      { "sata1", NULL, 30, 0 },

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com