? 2015?06?15? 23:00, Paul Bolle ??:

On Sun, 2015-06-14 at 13:13 +0800, Caesar Wang wrote:

quoted

--- /dev/null
+++ b/drivers/soc/rockchip/Kconfig
+config PM_GENERIC_DOMAINS
+        tristate "Rockchip generic power domain"

Since my remarks on v13 you removed the module specific code from
pm_domains.c. But now this became a tristate symbol. That makes little
sense. Why didn't you keep bool?

Yeah, you are right. :s/tristate/bool

I forget it when the driver is moving from 'arch/arm/mach-rockchip/' to 
'/driver/soc/rockchip/'.

quoted

+        depends on PM
+        help
+          Say y here to enable power doamin support.

s/doamin/domain/.

Done.

quoted

+          In order to meet high performance and low power requirements, a power
+          management unit is designed or saving power when RK3288 in low power
+          mode. The RK3288 PMU is dedicated for managing the power ot the whole chip.

s/ot/of/

Done.

quoted

+          If unsure, say N.

Thanks,


Paul Bolle

Thanks,

Caesar

-- 
Thanks,
- Caesar