Thread (27 messages) 27 messages, 2 authors, 2015-06-15

[RESEND PATCH v4 04/14] crypto: add a new driver for Marvell's CESA

From: herbert@gondor.apana.org.au (Herbert Xu)
Date: 2015-06-15 09:55:16
Also in: linux-crypto, linux-devicetree, lkml

On Fri, Jun 12, 2015 at 09:15:56AM +0200, Boris Brezillon wrote:
+static int mv_cesa_cbc_aes_op(struct ablkcipher_request *req,
+			      struct mv_cesa_op_ctx *tmpl)
+{
+	mv_cesa_update_op_cfg(tmpl, CESA_SA_DESC_CFG_CRYPTCM_CBC,
+			      CESA_SA_DESC_CFG_CRYPTCM_MSK);
+	memcpy(tmpl->ctx.blkcipher.iv, req->info, 16);
You need to copy the IV back into req->info after completion.

Incidentally we don't seem to test for output IVs in our self-
test so bugs like this can slip through until someone tries to
do chaining with it.  That's something worth adding to testmgr.

Cheers,
-- 
Email: Herbert Xu [off-list ref]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help