[PATCH v2 2/2] mmc: sdhci-bcm2835: Actually enable the clock

From
Stephen Warren <hidden>
Date
2015-06-05 02:59:55
Also in
linux-mmc, lkml
Reply to
Eric Anholt, 2015-05-29
On 05/29/2015 03:06 PM, Eric Anholt wrote:
We're currently using a fixed frequency clock specified in the DT, so
enabling is a no-op.  However, the RPi firmware-based clocks driver
can actually disable unused clocks, so when switching to use it we
ended up losing our MMC clock once all devices were probed.
quoted hunk ↗ jump to hunk
diff --git a/drivers/mmc/host/sdhci-bcm2835.c b/drivers/mmc/host/sdhci-bcm2835.c
quoted hunk ↗ jump to hunk
+	ret = clk_prepare_enable(pltfm_host->clk);
+	if (ret) {
+		dev_err(&pdev->dev, "failed to enable host clk\n");
+		goto err;
+	}
Given that pltfm_host is a "struct sdhci_pltfm_host" i.e. a type
defined/handled by sdhci-pltfm.c , I'm rather surprised that
sdhci-pltfm.c doesn't do this itself. Wouldn't it make sense for it to
do so?
Thread (6 messages) 6 messages, 3 authors, last reply 2015-06-05
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help