Thread (1 message) 1 message, 1 author, 2015-06-01

[PATCH] fixup! dmaengine: pxa_dma: add debug information

From: robert.jarzmik@free.fr (Robert Jarzmik)
Date: 2015-06-01 21:33:39
Also in: lkml

Joe Perches [off-list ref] writes:
Hello Robert.

The return value of that dbg_show_requester_chan function
was incorrect and the increment of pos was an example of
why the seq_printf return value was changed to void.

It was a pretty common error and easy to understand given
the expectation that seq_printf should work like printf.
Sure.
It's a pity it bit you. but this type of patch collision
should be a bit more difficult to reoccur in the future.
I got what I deserved. I knew it was coming, I've seen it in other drivers of
mine, but my left brain didn't tell the other half to crosscheck in this
patch. Anyway, it's not a big fixup, so everything is fine now.

Cheers.


-- 
Robert
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help