[PATCH net-next 00/11] convert stmmac glue layers into platform drivers

From
Giuseppe CAVALLARO <hidden>
Date
2015-05-15 07:45:47
Also in
linux-rockchip, netdev
Reply to
Chen-Yu Tsai, 2015-05-14
Hello

On 5/14/2015 5:24 PM, Chen-Yu Tsai wrote:
On Thu, May 14, 2015 at 6:10 PM, Joachim Eastwood [off-list ref] wrote:
quoted
This patch set aims to convert the current dwmac glue layers into
proper platform drivers as request by Arnd[1]. These changes start
from patch 3 and onwards.

Overview:
Platform driver functions like probe and remove are exported from
the stmmac platform and then used in subsequent glue later
conversions. The conversion involes adding the platform driver
boiler plate code and adding it to the build system. The last patch
removes the driver from the stmmac platform code thus making it into
a library for common platform driver functions.

The two first patches adds glue layer for my platform. I chose to
first add old style glue layer and then convert it. The churn this
creates is just 3 lines.

I would be very nice if people could test this patch set on their
respective platform. My testing has been limited to compiling and
testing on my (LPC18xx) platform. Thanks!
I wonder if this will make the compatibility with old
platforms (like SH4) not based on DT, where there was not used
any glue-logic around the driver and just the platform was the
reference.

To be honest, I prefer to not have the Kconfig options.
The device-tree compatibility will select the glue-logic
needed and we will just pay some bytes when compile.

In my opinion, the Koption(s) introduce a problem when touch
the driver and we want to guarantee that, at least,
all its parts build fine on all the platforms.

Regards,
Peppe
Tested-by: Chen-Yu Tsai <redacted>

on sunxi boards Cubietruck and Hummingbird A31.
quoted
Next I will look into cleaning up the stmmac platform code.

[1] http://marc.info/?l=linux-arm-kernel&m=143059524606459&w=2

Joachim Eastwood (11):
   stmmac: add dwmac glue for NXP 18xx/43xx family
   doc: dt: add documentation for nxp,lpc1850-dwmac
   stmmac: prepare stmmac platform to support stand alone drivers
   stmmac: add a generic dwmac driver
   stmmac: convert dwmac-lpc18xx to a platform driver
   stmmac: convert dwmac-meson to platform driver
   stmmac: convert dwmac-rk to platform driver
   stmmac: convert dwmac-socfpga to platform driver
   stmmac: convert dwmac-sti to platform driver
   stmmac: convert dwmac-sunxi to platform driver
   stmmac: drop driver from stmmac platform code

  .../devicetree/bindings/net/nxp,lpc1850-dwmac.txt  | 20 +++++
  drivers/net/ethernet/stmicro/stmmac/Kconfig        | 76 +++++++++++++++++
  drivers/net/ethernet/stmicro/stmmac/Makefile       | 13 ++-
  .../net/ethernet/stmicro/stmmac/dwmac-generic.c    | 41 +++++++++
  .../net/ethernet/stmicro/stmmac/dwmac-lpc18xx.c    | 99 ++++++++++++++++++++++
  drivers/net/ethernet/stmicro/stmmac/dwmac-meson.c  | 24 +++++-
  drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c     | 27 +++++-
  .../net/ethernet/stmicro/stmmac/dwmac-socfpga.c    | 21 ++++-
  drivers/net/ethernet/stmicro/stmmac/dwmac-sti.c    | 29 ++++++-
  drivers/net/ethernet/stmicro/stmmac/dwmac-sunxi.c  | 25 +++++-
  .../net/ethernet/stmicro/stmmac/stmmac_platform.c  | 49 ++---------
  .../net/ethernet/stmicro/stmmac/stmmac_platform.h  |  9 +-
  12 files changed, 378 insertions(+), 55 deletions(-)
  create mode 100644 Documentation/devicetree/bindings/net/nxp,lpc1850-dwmac.txt
  create mode 100644 drivers/net/ethernet/stmicro/stmmac/dwmac-generic.c
  create mode 100644 drivers/net/ethernet/stmicro/stmmac/dwmac-lpc18xx.c

--
1.8.0
Thread (18 messages) 18 messages, 6 authors, last reply 2015-05-15
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help