Thread (4 messages) 4 messages, 3 authors, 2015-05-12
STALE4064d

[PATCH v3 1/4] ARM: pxa: add memory resource to RTC device

From: Russell King - ARM Linux <hidden>
Date: 2015-05-12 20:36:13
Also in: linux-rtc

On Tue, May 12, 2015 at 10:30:12PM +0200, Arnd Bergmann wrote:
On Tuesday 12 May 2015 22:24:49 Robert Jarzmik wrote:
quoted
I made the try, and Russell was right, this breaks the pxa architecture. The
relevant extract of kernel message is in [1].

The consequences with your patches :
 - pxa27x_init()
   - platform_add_devices()
     - the pxa_device_rtc fails (as resource is duplicated)
     - all the devices are unregistered (rollback)
And pxa27x fails.

Now I'm pondering about the right approach :
 - either remove sa1100_device_rtc from pxas
 - or remove pxa_device_rtc
 - or both
 - or something else

Let me think a bit about it.
To solve the problem with the duplicate registration of one resource,
I'd suggest using platform_device_register_simple() for the registration,
which will copy the resource. You can then mark the resource as __initconst
and remove the device to save a little memory at runtime.
No, a better solution is to solve the problem which requires the
duplication in the first place, which is a broken driver structure.

-- 
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help