Thread (8 messages) 8 messages, 2 authors, 2015-05-12
STALE4059d
Revisions (6)
  1. v1 [diff vs current]
  2. v2 [diff vs current]
  3. v3 [diff vs current]
  4. v3 [diff vs current]
  5. v3 current
  6. v3 [diff vs current]

[PATCH v3 1/4] ARM: pxa: add memory resource to RTC device

From: robh@kernel.org (Rob Herring)
Date: 2015-05-12 00:35:24
Also in: linux-rtc

On Mon, May 11, 2015 at 5:49 PM, Russell King - ARM Linux
[off-list ref] wrote:
On Mon, May 11, 2015 at 05:41:26PM -0500, Rob Herring wrote:
quoted
Add the memory resource for the sa1100-rtc device. Since the memory
resource is already present in the pxa_rtc_resources, that makes
sa1100_rtc_resources and pxa_rtc_resources equivalent, so use
pxa_rtc_resources for both devices and remove the duplicate
sa1100_rtc_resources.
This really isn't a good idea - what do you think happens when
the same struct resource gets passed into insert_resource()
twice?
Bad things. If you recall, we discussed this on v1[1]. See the commit
msg of patch 2 for the summary. There is not currently a problem
because the rtc-pxa driver does not request the resource.

Rob

[1] http://lists.infradead.org/pipermail/linux-arm-kernel/2015-February/322355.html
--
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help