On Fri, May 29, 2015 at 4:25 PM, Mika Westerberg
[off-list ref] wrote:

On Thu, May 28, 2015 at 01:46:28PM +0700, Y Vo wrote:

quoted

+#ifdef CONFIG_ACPI
+     if (priv->nirq > 0) {
+             /* Register interrupt handlers for gpio signaled acpi events */
+             acpi_gpiochip_request_interrupts(&priv->bgc.gc);
+     }
+#endif

You don't need to check CONFIG_ACPI as acpi_gpiochip_request_interrupts()
will be stubbed out if !CONFIG_ACPI.

I will remove this check.

Should you call acpi_gpiochip_free_interrupts() somewhere to unregister
the interrupts as well?

I will add this to xgene_gpio_sb_remove function.

Even better if you can switch your driver to use GPIOLIB_IRQCHIP all
this is done automatically for you.