[PATCH 1/2] phy: add lpc18xx usb otg phy driver

Hi Kishon,

On 21 May 2015 at 14:55, Kishon Vijay Abraham I [off-list ref] wrote:

Hi,


On Saturday 16 May 2015 10:57 PM, Joachim Eastwood wrote:

quoted

Add PHY driver for the internal USB OTG PHY found on NXP
LPC18xx and LPC43xx devices. This driver takes care of
enabling the PHY in CREG (syscon) and setting the required
clock frequency.

Signed-off-by: Joachim Eastwood <redacted>
---

<snip>

quoted

+/* USB OTG PHY register offset and bit in CREG */
+#define LPC18XX_CREG_CREG0             0x004
+# define LPC18XX_CREG_CREG0_USB0PHY    BIT(5)

don't prefer a space between # and define. Not a strong feeling though.

Okey, I'll remove it.

quoted

+
+       phy_provider = devm_of_phy_provider_register(&pdev->dev,
+                                                    of_phy_simple_xlate);
+       if (IS_ERR(phy_provider))
+               return PTR_ERR(phy_provider);
+
+       return 0;

replace it with return PTR_ERR_OR_ZERO(phy_provider);

Okey.


Thanks for the review, Kishon.

I'll send a updated version later today.


regards,
Joachim Eastwood