On Wed, May 20, 2015 at 9:46 AM, Joshua Clayton
[off-list ref] wrote:

quoted

+       snvs_np = of_get_parent(pdev->dev.of_node);
+       if (!snvs_np)
+               return -ENODEV;
+
+       data->snvs = syscon_node_to_regmap(snvs_np);
+       of_node_put(snvs_np);
+
+       if (!data->snvs) {
+               pr_err("Can't snvs syscon\n");
+               return -ENODEV;
+       }

How about change error message to " Can't snvs syscon, probably use
old dts file"?

How about simply: "Cannot find snvs syscon node in devicetree."

Shawn:
          Are you okay for that?

best regards
Frank Li

--
~Joshua Clayton